Personally I love the Guthub dark mode settings. I really like the background to be near total black, and they got a nice balance from my perspective of what I find really enjoyable.
I say kudos to GitHub. I wonder how much they may have gleaned from telemetry with VSCode and user settings there. That’s a wealth of information for this type of decision.
I completely agree, and it’s one of my favorite dark modes ever. In my editors, I also use #000 backgrounds. I think this is the sort of “can’t please everyone” type situation which warrants even more options. If there are accessibility concerns, they should absolutely add a more accessible option with better contrast (and it should probably be the default if so - I really do wonder if it’s actually inaccessible). IIRC, more color options are on the roadmap? Perhaps I misremember.
FWIW, I'm red-green colour blind (quite badly), and often prefer more contrast to see colour delineations clearly - and I think GitHub's new dark mode is perfect.
I’m with you. I honestly don’t understand this vehement opposition. I guarantee you if something like the Dark Reader extension applied this same exact theme nobody would think twice about it.
I say kudos to GitHub. I wonder how much they may have gleaned from telemetry with VSCode and user settings there. That’s a wealth of information for this type of decision.